Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-54192: Make VNC Console in the Overview page read only #2407

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

rszwajko
Copy link
Collaborator

📝 Description

Toggle viewOnly flag and adjust cursor styling.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 31, 2025

@rszwajko: This pull request references CNV-54192 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

Toggle viewOnly flag and adjust cursor styling.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@upalatucci
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jan 31, 2025
Copy link
Contributor

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rszwajko, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jan 31, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 06f5048 into kubevirt-ui:main Jan 31, 2025
10 checks passed
@upalatucci
Copy link
Member

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link
Collaborator

@upalatucci: #2407 failed to apply on top of branch "release-4.17":

Applying: Make VNC Console in the Overview page read only
Using index info to reconstruct a base tree...
M	src/utils/components/Consoles/components/vnc-console/vnc-console.scss
M	src/views/virtualmachines/details/tabs/overview/components/VirtualMachinesOverviewTabDetails/components/VirtualMachinesOverviewTabDetailsConsole.tsx
Falling back to patching base and 3-way merge...
Auto-merging src/views/virtualmachines/details/tabs/overview/components/VirtualMachinesOverviewTabDetails/components/VirtualMachinesOverviewTabDetailsConsole.tsx
CONFLICT (content): Merge conflict in src/views/virtualmachines/details/tabs/overview/components/VirtualMachinesOverviewTabDetails/components/VirtualMachinesOverviewTabDetailsConsole.tsx
Auto-merging src/utils/components/Consoles/components/vnc-console/vnc-console.scss
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Make VNC Console in the Overview page read only

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants