Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-47203: Display Automatic subscription section with incomplete data #2385

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

rszwajko
Copy link
Collaborator

📝 Description

Feature flag is retrieved from/saved to the server which introduces delay. Before this fix nothing was rendered when waiting for the flag. After this fix the UI will be rendered with following safety measures:

  1. callback to toggle the feature will be disabled
  2. on initial load (no data) the switch will be disabled

🎥 Demo

Before

Screencast.from.2025-01-23.15-16-22.mp4

After

Screencast.from.2025-01-23.15-14-04.mp4

Feature flag is retrieved from/saved to the server which introduces
delay. Before this fix nothing was rendered when waiting for the flag.
After this fix the UI will be rendered with following safety measures:
1. callback to toggle the feature will be disabled
2. on initial load (no data) the switch will be disabled

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 23, 2025

@rszwajko: This pull request references CNV-47203 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

Feature flag is retrieved from/saved to the server which introduces delay. Before this fix nothing was rendered when waiting for the flag. After this fix the UI will be rendered with following safety measures:

  1. callback to toggle the feature will be disabled
  2. on initial load (no data) the switch will be disabled

🎥 Demo

Before

Screencast.from.2025-01-23.15-16-22.mp4

After

Screencast.from.2025-01-23.15-14-04.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from pcbailey and upalatucci January 23, 2025 14:28
@rszwajko rszwajko requested a review from metalice January 23, 2025 14:28
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jan 23, 2025
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rszwajko, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jan 23, 2025
@upalatucci
Copy link
Member

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 72d6a41 into kubevirt-ui:main Jan 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants