-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-55112: Limit VM name length to max k8s label length (63 characters) #2379
CNV-55112: Limit VM name length to max k8s label length (63 characters) #2379
Conversation
@pcbailey: This pull request references CNV-55112 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
...alog/templatescatalog/components/TemplatesCatalogDrawer/TemplatesCatalogDrawerCreateForm.tsx
Outdated
Show resolved
Hide resolved
bb29660
to
bbaf932
Compare
...s/catalog/CreateFromInstanceTypes/components/VMDetailsSection/components/DetailsLeftGrid.tsx
Outdated
Show resolved
Hide resolved
...s/catalog/CreateFromInstanceTypes/components/VMDetailsSection/components/DetailsLeftGrid.tsx
Outdated
Show resolved
Hide resolved
...alog/templatescatalog/components/TemplatesCatalogDrawer/TemplatesCatalogDrawerCreateForm.tsx
Outdated
Show resolved
Hide resolved
...alog/templatescatalog/components/TemplatesCatalogDrawer/TemplatesCatalogDrawerCreateForm.tsx
Outdated
Show resolved
Hide resolved
bbaf932
to
2231014
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
This PR adds limits the length of VM names to the maximum k8s label length of 63 characters. Names larger than this cause errors when migrating VMs.
Jira: https://issues.redhat.com/browse/CNV-55112
🎥 Screenshots
Create VM from InstanceTypes
Template drawer
VM name modal