Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-55112: Limit VM name length to max k8s label length (63 characters) #2379

Conversation

pcbailey
Copy link
Member

📝 Description

This PR adds limits the length of VM names to the maximum k8s label length of 63 characters. Names larger than this cause errors when migrating VMs.

Jira: https://issues.redhat.com/browse/CNV-55112

🎥 Screenshots

Create VM from InstanceTypes

vm-name-length-validation--instancetypes--invalid--AFTER--2025-01-21_09-23

vm-name-length-validation--instancetypes--valid--AFTER--2025-01-21_09-24

Template drawer

vm-name-length-validation--drawer--invalid--AFTER--2025-01-21_10-17

vm-name-length-validation--drawer--valid--AFTER--2025-01-21_10-18

VM name modal

vm-name-length-validation--modal--invalid--AFTER--2025-01-21_10-30

vm-name-length-validation--modal--valid--AFTER--2025-01-21_10-31

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 21, 2025

@pcbailey: This pull request references CNV-55112 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

This PR adds limits the length of VM names to the maximum k8s label length of 63 characters. Names larger than this cause errors when migrating VMs.

Jira: https://issues.redhat.com/browse/CNV-55112

🎥 Screenshots

Create VM from InstanceTypes

vm-name-length-validation--instancetypes--invalid--AFTER--2025-01-21_09-23

vm-name-length-validation--instancetypes--valid--AFTER--2025-01-21_09-24

Template drawer

vm-name-length-validation--drawer--invalid--AFTER--2025-01-21_10-17

vm-name-length-validation--drawer--valid--AFTER--2025-01-21_10-18

VM name modal

vm-name-length-validation--modal--invalid--AFTER--2025-01-21_10-30

vm-name-length-validation--modal--valid--AFTER--2025-01-21_10-31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jan 21, 2025
@pcbailey pcbailey force-pushed the bug-fix-vm-name-length-validation branch from bb29660 to bbaf932 Compare January 21, 2025 23:17
@pcbailey pcbailey force-pushed the bug-fix-vm-name-length-validation branch from bbaf932 to 2231014 Compare January 22, 2025 14:45
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jan 22, 2025
Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1874ece into kubevirt-ui:main Jan 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants