Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-55114: fix migrations action cancel statuses #2369

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Jan 16, 2025

📝 Description

In VM list we fetch all vmi migrations and create a structure to organize them by VM.
But for each VM we save only one migration and sometimes we take an old migration that has been completed but there is a more recent one that is in progress .
So we have to sort them out and take the more recent one to understand if we have to show the cancel button or not.

🎥 Demo

Before
Screenshot 2025-01-16 at 11 43 29
Screenshot 2025-01-16 at 11 43 37

Screenshot 2025-01-16 at 11 40 26

After

Screenshot 2025-01-16 at 11 45 03

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 16, 2025

@upalatucci: This pull request references CNV-55114 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

Add a brief description

🎥 Demo

Before
Screenshot 2025-01-16 at 11 43 29
Screenshot 2025-01-16 at 11 43 37

Screenshot 2025-01-16 at 11 40 26

After

Screenshot 2025-01-16 at 11 45 03

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jan 16, 2025
@gouyang
Copy link
Member

gouyang commented Jan 16, 2025

@upalatucci Can we improve the button text?
If it's migrating VM to another node, the text is "Cancel compute migration".
If it's storageclass migration, the text is "Cancel storage migration".

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 20, 2025

@upalatucci: This pull request references CNV-55114 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

In VM list we fetch all vmi migrations and create a structure to organize them by VM.
But for each VM we save only one migration and sometimes we take an old migration that has been completed but there is a more recent one that is in progress .
So we have to sort them out and take the more recent one to understand if we have to show the cancel button or not.

🎥 Demo

Before
Screenshot 2025-01-16 at 11 43 29
Screenshot 2025-01-16 at 11 43 37

Screenshot 2025-01-16 at 11 40 26

After

Screenshot 2025-01-16 at 11 45 03

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@upalatucci
Copy link
Member Author

@gouyang I'll address it in the rollback migration bug

@upalatucci
Copy link
Member Author

here #2368

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jan 21, 2025
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 361dfa9 into kubevirt-ui:main Jan 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants