-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-55114: fix migrations action cancel statuses #2369
CNV-55114: fix migrations action cancel statuses #2369
Conversation
@upalatucci: This pull request references CNV-55114 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@upalatucci Can we improve the button text? |
@upalatucci: This pull request references CNV-55114 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@gouyang I'll address it in the rollback migration bug |
here #2368 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
In VM list we fetch all vmi migrations and create a structure to organize them by VM.
But for each VM we save only one migration and sometimes we take an old migration that has been completed but there is a more recent one that is in progress .
So we have to sort them out and take the more recent one to understand if we have to show the cancel button or not.
🎥 Demo
Before
After