Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-51418: disable delete on running vm #2281

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

upalatucci
Copy link
Member

📝 Description

We don't want to enable delete action on running vms

🎥 Demo

Screenshot 2024-11-22 at 12 37 58

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 22, 2024

@upalatucci: This pull request references CNV-51418 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

We don't want to enable delete action on running vms

🎥 Demo

Screenshot 2024-11-22 at 12 37 58

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avivtur and pcbailey November 22, 2024 11:38
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Nov 22, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 24, 2024
Copy link
Contributor

openshift-ci bot commented Nov 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upalatucci
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit f0766cd into kubevirt-ui:main Nov 24, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants