Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-51588: Fix network selection behavior change in Add network interface modal #2279

Conversation

pcbailey
Copy link
Member

📝 Description

The component used to select a network in the "Add network interface" modal was recently changed to a typeahead component exhibiting the standard selection behavior found in the Patternfly typeahead component [1]. This change introduced a change in behavior where selecting the currently selected option deselects that option and reverts to a placeholder value.

This PR modifies the behavior such that selecting the currently selected option does nothing.

Jira: https://issues.redhat.com/browse/CNV-51588

[1] https://v5-archive.patternfly.org/components/menus/select/react-templates/#typeahead

🎥 Demo

Before

select-nad-behavior-change--BEFORE--2024-11-21.16-44.webm

After

select-nad-behavior-change--AFTER--2024-11-21.15-58.webm

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 21, 2024

@pcbailey: This pull request references CNV-51588 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

The component used to select a network in the "Add network interface" modal was recently changed to a typeahead component exhibiting the standard selection behavior found in the Patternfly typeahead component [1]. This change introduced a change in behavior where selecting the currently selected option deselects that option and reverts to a placeholder value.

This PR modifies the behavior such that selecting the currently selected option does nothing.

Jira: https://issues.redhat.com/browse/CNV-51588

[1] https://v5-archive.patternfly.org/components/menus/select/react-templates/#typeahead

🎥 Demo

Before

select-nad-behavior-change--BEFORE--2024-11-21.16-44.webm

After

select-nad-behavior-change--AFTER--2024-11-21.15-58.webm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Nov 21, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 22, 2024
Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pcbailey,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a6599bf into kubevirt-ui:main Nov 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants