CNV-41403: localize loading #2221
Conversation
|
@upalatucci: This pull request references CNV-41403 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
src/utils/components/EnvironmentEditor/components/EnvironmentEditor.tsx
Outdated
Show resolved
Hide resolved
src/utils/components/EnvironmentEditor/components/EnvironmentEditor.tsx
Outdated
Show resolved
Hide resolved
| @@ -72,15 +82,17 @@ const DiskRow: FC< | |||
| </TableData> | |||
|
|
|||
| <TableData activeColumnIDs={activeColumnIDs} id="source"> | |||
| {isPVCSource(obj) ? ( | |||
| {sourcesLoaded && hasPVC && ( | |||
There was a problem hiding this comment.
Is sourcesLoaded needed because it affects the hasPVC const?
There was a problem hiding this comment.
Why does it affect the const?
upalatucci
force-pushed
the
storage-tab-loading
branch
from
a3518b4 to
61358bc
Compare
src/utils/components/EnvironmentEditor/components/EnvironmentSelectResource.tsx
Outdated
Show resolved
Hide resolved
src/utils/components/EnvironmentEditor/components/EnvironmentSelectResource.tsx
Outdated
Show resolved
Hide resolved
src/utils/components/EnvironmentEditor/components/EnvironmentSelectResource.tsx
Outdated
Show resolved
Hide resolved
upalatucci
force-pushed
the
storage-tab-loading
branch
from
61358bc to
1f521f6
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/cherry-pick release-4.17 |
|
@upalatucci: new pull request created: #2225 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 Description
disk list loading is just for fetching PVC so we don't have to show the list loading
for environment list the loading is just for selecting new items, so we can show the loading only on the select if visible.
(We can't show loading inside the select dropdown for a patternfly bug)
🎥 Demo
Before
https://issues.redhat.com/secure/attachment/13183584/storage_reload_times.mp4
After
Screen.Recording.2024-10-09.at.10.42.35.mov