CNV-49299: use runStrategy on cloning

[upalatucci]

📝 Description

spec.running and spec.runStrategy are mutual exclusive. YAML example now use spec.runStrategy so patching the VM with spec.running: true does not work. So if the VM use spec.running patch that spec attribute otherwise use spec.runStrategy

[openshift-ci-robot]

@upalatucci: This pull request references CNV-49299 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

spec.running and spec.runStrategy are mutual exclusive. YAML example now use spec.runStrategy so patching the VM with spec.running: true does not work. So if the VM use spec.running patch that spec attribute otherwise use spec.runStrategy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[metalice]

@upalatucci, why not just change the example yaml? Its ours isn't it? or you are thinking about a case of user yaml with runstrategy ?

[upalatucci]

spec.runStrategy is the modern way to define the VM behavior. We should always use that instead of spec.running. It gives the user more flexibility on how the VM should behave in case of failures. This is why the example yaml was changed from spec.running to spec.runStrategy.
Other than that, I think our code should be flexible and be able to start vms that use both mechanisms

[avivtur]

What about when running can be false? there are also cases where someone would like to pass a different runStrategy the Always?

[upalatucci]

If rspec.running is false, it means that the user used this attribute to run/stop the VM so we'll use the same s[attribute changing the spec.running . If it's not in the vm spec it means that we'll use runStrategy

I can at this point call the vm API action to run the vm, so the backend will choose what strategy use.

[upalatucci]

runStrategies that start vms are Always and RerunOnFailure

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment