Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-45253: No color in the virtual machine migration graph legend #2198

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Sep 24, 2024

📝 Description

Adding a color array to match chart data and chart legend

🎥 Demo

Before

migrations-chart-legend-b4

After

migrations-chart-legend

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 24, 2024

@avivtur: This pull request references CNV-45253 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

Adding a color array to match chart data and chart legend

🎥 Demo

After

migrations-chart-legend

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Sep 24, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 24, 2024

@avivtur: This pull request references CNV-45253 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

Adding a color array to match chart data and chart legend

🎥 Demo

Before

migrations-chart-legend-b4

After

migrations-chart-legend

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Sep 24, 2024
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6056c50 into kubevirt-ui:main Sep 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants