Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-46660: Enable pvc resize on vm disks #2182

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

upalatucci
Copy link
Member

📝 Description

User can edit the PVC size from the disk modal.

Let the user only expand the size if the PVC is created.

If the PVC is not created, we can change that from the data volume structure just like before.

I deleted the isCreated prop from Diskmodal and created a new one called createdPVCName. If this prop exists, the PVC already exists, so we can't change the source.

🎥 Demo

Before

Screenshot 2024-09-16 at 15 09 53

After

Screen.Recording.2024-09-16.at.14.54.33.mov

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 16, 2024

@upalatucci: This pull request references CNV-46660 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.18.0" instead.

In response to this:

📝 Description

User can edit the PVC size from the disk modal.

Let the user only expand the size if the PVC is created.

If the PVC is not created, we can change that from the data volume structure just like before.

I deleted the isCreated prop from Diskmodal and created a new one called createdPVCName. If this prop exists, the PVC already exists, so we can't change the source.

🎥 Demo

Before

Screenshot 2024-09-16 at 15 09 53

After

Screen.Recording.2024-09-16.at.14.54.33.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Sep 16, 2024
@metalice
Copy link
Member

@upalatucci isnt it easier and more clear instead of doing in many failed isCreated? expand : diskinputsize

to add this check into diskinputsize?

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Sep 19, 2024
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3533363 into kubevirt-ui:main Sep 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants