-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-46660: Enable pvc resize on vm disks #2182
Conversation
@upalatucci: This pull request references CNV-46660 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.18.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@upalatucci isnt it easier and more clear instead of doing in many failed isCreated? expand : diskinputsize to add this check into diskinputsize? |
44854b1
to
9b7ab43
Compare
9b7ab43
to
52b9c10
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
User can edit the PVC size from the disk modal.
Let the user only expand the size if the PVC is created.
If the PVC is not created, we can change that from the data volume structure just like before.
I deleted the
isCreated
prop from Diskmodal and created a new one calledcreatedPVCName
. If this prop exists, the PVC already exists, so we can't change the source.🎥 Demo
Before
After
Screen.Recording.2024-09-16.at.14.54.33.mov