Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-46660: show disk pvc not the original source #2175

Merged

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Sep 16, 2024

📝 Description

Before

VM disk list show the original PVC where data source clone the data for the disk

VM -> DataSource -> PVC (source cloned)

The PVC that you see here is not the PVC that the VM will use but what the datavolume will clone. This will probably create confusion to the user.

Screenshot 2024-09-16 at 08 56 47

After

Vm disk list show the actual PVC used by the VM

VM -> DataVolume -> Actual PVC used (The one that we have to resize, not the source cloned)

Screenshot 2024-09-16 at 08 55 57

Why we did that?

Because in the instancetype we want to show in the disk list the source size that will be cloned. In order to do that, we have to set the storage.resources.requests.storage property

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 16, 2024

@upalatucci: This pull request references CNV-46660 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.18.0" instead.

In response to this:

📝 Description

Before

VM disk list show the original PVC where data source clone the data for the disk

VM -> DataSource -> PVC (source cloned)

After

Vm disk list show the actual PVC used by the VM

VM -> DataVolume -> Actual PVC used (The one that we have to resize, not the source cloned)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from metalice and tnisan September 16, 2024 06:37
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Sep 16, 2024
@upalatucci upalatucci changed the title CNV-46660: show disk pvc not the original source [WIP] CNV-46660: show disk pvc not the original source Sep 16, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 16, 2024

@upalatucci: This pull request references CNV-46660 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.18.0" instead.

In response to this:

📝 Description

Before

VM disk list show the original PVC where data source clone the data for the disk

VM -> DataSource -> PVC (source cloned)

After

Vm disk list show the actual PVC used by the VM

VM -> DataVolume -> Actual PVC used (The one that we have to resize, not the source cloned)

Why we did that?

Because in the instancetype we want to show in the disk list the source size that will be cloned. But we have to find another way to show that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 16, 2024

@upalatucci: This pull request references CNV-46660 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.18.0" instead.

In response to this:

📝 Description

Before

VM disk list show the original PVC where data source clone the data for the disk

VM -> DataSource -> PVC (source cloned)

After

Vm disk list show the actual PVC used by the VM

VM -> DataVolume -> Actual PVC used (The one that we have to resize, not the source cloned)

Why we did that?

Because in the instancetype we want to show in the disk list the source size that will be cloned. In order to do that, we have to set the storage.resources.requests.storage property

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@upalatucci upalatucci force-pushed the fix-pvc-source-disk-list branch from 9b05333 to e73ff87 Compare September 16, 2024 06:56
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 16, 2024

@upalatucci: This pull request references CNV-46660 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.18.0" instead.

In response to this:

📝 Description

Before

VM disk list show the original PVC where data source clone the data for the disk

VM -> DataSource -> PVC (source cloned)

The PVC that you see here is not the PVC that the VM will use but what the datavolume will clone. This will probably create confusion to the user.

Screenshot 2024-09-16 at 08 56 47

After

Vm disk list show the actual PVC used by the VM

VM -> DataVolume -> Actual PVC used (The one that we have to resize, not the source cloned)

Screenshot 2024-09-16 at 08 55 57

Why we did that?

Because in the instancetype we want to show in the disk list the source size that will be cloned. In order to do that, we have to set the storage.resources.requests.storage property

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@upalatucci upalatucci changed the title [WIP] CNV-46660: show disk pvc not the original source CNV-46660: show disk pvc not the original source Sep 16, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Sep 16, 2024
Copy link
Contributor

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 600bfdb into kubevirt-ui:main Sep 16, 2024
10 checks passed
@metalice
Copy link
Member

@upalatucci i dont see SC and PVC link in the after screen shot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants