Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-43594: Fix bootable incloning #2167

Merged

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Sep 9, 2024

📝 Description

DataSource CloneInProgress is a state that now depends on a condition in the DataImportCron.
Now there is no condition in the DataSource that indicates whether it's cloning or not

It can take a couple of seconds to show up but it's okay I think

🎥 Demo

Bootable Volumes list
Screenshot 2024-09-09 at 11 56 08

Create instance type bootable volume list (last item)
Screenshot 2024-09-09 at 12 08 05

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Sep 9, 2024
@upalatucci upalatucci force-pushed the fix-bootable-incloning branch from 887973e to 5da1cb1 Compare September 9, 2024 10:09
@upalatucci upalatucci changed the title Fix bootable incloning CNV-43594: Fix bootable incloning Sep 9, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 9, 2024

@upalatucci: This pull request references CNV-43594 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

DataSource CloneInProgress is a state that now depends on a condition in the DataImportCron.
Now there is no condition in the DataSource that indicates whether it's cloning or not

🎥 Demo

Bootable Volumes list
Screenshot 2024-09-09 at 11 56 08

Create instance type bootable volume list (last item)
Screenshot 2024-09-09 at 12 08 05

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 9, 2024

@upalatucci: This pull request references CNV-43594 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

DataSource CloneInProgress is a state that now depends on a condition in the DataImportCron.
Now there is no condition in the DataSource that indicates whether it's cloning or not

It can take a couple of seconds to show up but it's okay I think

🎥 Demo

Bootable Volumes list
Screenshot 2024-09-09 at 11 56 08

Create instance type bootable volume list (last item)
Screenshot 2024-09-09 at 12 08 05

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 9, 2024

@upalatucci: This pull request references CNV-43594 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

DataSource CloneInProgress is a state that now depends on a condition in the DataImportCron.
Now there is no condition in the DataSource that indicates whether it's cloning or not

It can take a couple of seconds to show up but it's okay I think

🎥 Demo

Bootable Volumes list
Screenshot 2024-09-09 at 11 56 08

Create instance type bootable volume list (last item)
Screenshot 2024-09-09 at 12 08 05

Screen.Recording.2024-09-09.at.12.14.29.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 9, 2024

@upalatucci: This pull request references CNV-43594 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

DataSource CloneInProgress is a state that now depends on a condition in the DataImportCron.
Now there is no condition in the DataSource that indicates whether it's cloning or not

It can take a couple of seconds to show up but it's okay I think

🎥 Demo

Bootable Volumes list
Screenshot 2024-09-09 at 11 56 08

Create instance type bootable volume list (last item)
Screenshot 2024-09-09 at 12 08 05

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Sep 11, 2024
@upalatucci upalatucci force-pushed the fix-bootable-incloning branch from 5da1cb1 to f35749a Compare September 11, 2024 13:57
@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Sep 11, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Sep 12, 2024
Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e3548fb into kubevirt-ui:main Sep 12, 2024
11 checks passed
upalatucci pushed a commit to upalatucci/kubevirt-plugin that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants