Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-45860: Select 'Hide deprecated bootable volume' filter by default #2158

Conversation

pcbailey
Copy link
Member

@pcbailey pcbailey commented Sep 4, 2024

📝 Description

This PR causes the 'Hide deprecated bootable volume' filter to be selected by default on the Bootable volume list page and the InstanceTypes VM creation page.

Jira: https://issues.redhat.com/browse/CNV-45860

🎥 Demo

hide-deprecated-by-default--2024-09-13.21-29.webm

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 4, 2024

@pcbailey: This pull request references CNV-45860 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

This PR causes the 'Hide deprecated bootable volume' filter to be selected by default on the Bootable volume list page and the InstanceTypes VM creation page.

Jira: https://issues.redhat.com/browse/CNV-45860

🎥 Screenshots

Bootable volume list

select-bootable-volumes-by-default--list--AFTER--2024-09-04_11-28

InstanceTypes VM creation page

select-bootable-volumes-by-default--IT--AFTER--2024-09-04_11-26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avivtur and metalice September 4, 2024 15:35
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Sep 4, 2024
@pcbailey pcbailey force-pushed the feature-hide-deprecated-bootvolumes-by-default branch from faac683 to 3bf7a68 Compare September 9, 2024 00:49
@pcbailey pcbailey changed the title CNV-45860: Select 'Hide deprecated bootable volume' filter by default WIP: CNV-45860: Select 'Hide deprecated bootable volume' filter by default Sep 9, 2024
@pcbailey pcbailey force-pushed the feature-hide-deprecated-bootvolumes-by-default branch 2 times, most recently from d514d88 to b2173b6 Compare September 14, 2024 01:21
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 14, 2024

@pcbailey: This pull request references CNV-45860 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

This PR causes the 'Hide deprecated bootable volume' filter to be selected by default on the Bootable volume list page and the InstanceTypes VM creation page.

Jira: https://issues.redhat.com/browse/CNV-45860

🎥 Demo

hide-deprecated-by-default--2024-09-13.21-29.webm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pcbailey pcbailey changed the title WIP: CNV-45860: Select 'Hide deprecated bootable volume' filter by default CNV-45860: Select 'Hide deprecated bootable volume' filter by default Sep 14, 2024
@pcbailey pcbailey force-pushed the feature-hide-deprecated-bootvolumes-by-default branch from b2173b6 to 7be0969 Compare September 14, 2024 19:12
@pcbailey pcbailey force-pushed the feature-hide-deprecated-bootvolumes-by-default branch from 7be0969 to 2c5257c Compare September 17, 2024 02:14
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Sep 17, 2024
Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5df63b2 into kubevirt-ui:main Sep 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants