CNV-43592: Preference dropdown in 'Add volume' has no grouping for user/RH preferences #2151
Conversation
|
@avivtur: This pull request references CNV-43592 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -76,6 +66,20 @@ const InlineFilterSelect: FC<InlineFilterSelectProps> = ({ | |||
| [options, filterValue], | |||
| ); | |||
|
|
|||
| const groupedOptions = useMemo(() => { | |||
| import { NO_RESULTS } from './constants'; | ||
| import { EnhancedSelectOptionProps } from './types'; | ||
|
|
||
| export const getOptionComponent = (opt: EnhancedSelectOptionProps) => |
| opt?.children | ||
| ); | ||
|
|
||
| export const renderOptions = ( |
There was a problem hiding this comment.
why in a util file? can be a component
…er/RH preferences Signed-off-by: Aviv Turgeman <[email protected]>
avivtur
force-pushed
the
bug-group=preference-select-in-add-volume-modal
branch
from
bc7a6d7 to
d21ad5d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
Allow grouping in InlineFilterSelect component
🎥 Demo
Before:
After:
