-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-45441: New VM template: Use runStrategy
field instead of deprecated running
#2150
CNV-45441: New VM template: Use runStrategy
field instead of deprecated running
#2150
Conversation
…ated 'running' The 'running' field in the VirtualMachine's spec is being deprecated in kubevirt in favor of the 'runStrategy' field, therefore all examples show be using the runStrategy for specifying the requested running state of the VMI. Reference: kubevirt/kubevirt#11993 Signed-off-by: Oren Cohen <[email protected]>
@orenc1: This pull request references CNV-45441 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hi @orenc1. Thanks for your PR. I'm waiting for a kubevirt-ui member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: orenc1, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/test kubevirt-e2e-aws |
/cherry-pick release-4.17 |
@orenc1: only kubevirt-ui org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-4.17 |
@upalatucci: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 Description
The
running
field in the VirtualMachine's spec is being deprecated in kubevirt in favor of therunStrategy
field, therefore all examples show be using therunStrategy
for specifying the requested running state of the VMI.Reference: kubevirt/kubevirt#11993
🎥 Demo