Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-45441: New VM template: Use runStrategy field instead of deprecated running #2150

Conversation

orenc1
Copy link
Contributor

@orenc1 orenc1 commented Sep 3, 2024

📝 Description

The running field in the VirtualMachine's spec is being deprecated in kubevirt in favor of the runStrategy field, therefore all examples show be using the runStrategy for specifying the requested running state of the VMI.
Reference: kubevirt/kubevirt#11993

🎥 Demo

Please add a video or an image of the behavior/changes

…ated 'running'

The 'running' field in the VirtualMachine's spec is being deprecated in kubevirt in favor of the 'runStrategy' field, therefore all examples
show be using the runStrategy for specifying the requested running state of the VMI.
Reference: kubevirt/kubevirt#11993

Signed-off-by: Oren Cohen <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 3, 2024

@orenc1: This pull request references CNV-45441 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

The running field in the VirtualMachine's spec is being deprecated in kubevirt in favor of the runStrategy field, therefore all examples show be using the runStrategy for specifying the requested running state of the VMI.
Reference: kubevirt/kubevirt#11993

🎥 Demo

Please add a video or an image of the behavior/changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

Hi @orenc1. Thanks for your PR.

I'm waiting for a kubevirt-ui member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@upalatucci
Copy link
Member

/approve

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Sep 3, 2024
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Sep 3, 2024
Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metalice
Copy link
Member

metalice commented Sep 3, 2024

/ok-to-test

@orenc1
Copy link
Contributor Author

orenc1 commented Sep 3, 2024

/test kubevirt-e2e-aws

@openshift-merge-bot openshift-merge-bot bot merged commit f0103c3 into kubevirt-ui:main Sep 3, 2024
7 checks passed
@orenc1 orenc1 deleted the replace_running_with_runStrategy branch September 3, 2024 10:14
@orenc1
Copy link
Contributor Author

orenc1 commented Sep 3, 2024

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link
Collaborator

@orenc1: only kubevirt-ui org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@upalatucci
Copy link
Member

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link
Collaborator

@upalatucci: cannot checkout release-4.17: error checking out "release-4.17": exit status 1 error: pathspec 'release-4.17' did not match any file(s) known to git

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants