Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-45584: Fix new CPU inputs behavior in CPU/memory modal #2147

Merged

Conversation

pcbailey
Copy link
Member

@pcbailey pcbailey commented Aug 28, 2024

📝 Description

This PR updates the behavior of the new CPU inputs so that the vCPU count changes when the topology inputs are changed and that the vCPU input is disabled when the topology radio button is selected and vice versa.

Jira: https://issues.redhat.com/browse/CNV-45584

🎥 Demo

Before

updated-CPU-memory-modal--BEFORE--2024-08-28 08-45

After

updated-CPU-memory-modal--AFTER-with-text-changes--2024-08-30 10-41

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 28, 2024

@pcbailey: This pull request references CNV-45584 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

This PR updates the behavior of the new CPU inputs so that the vCPU count changes when the topology inputs are changed and that the vCPU input is disabled when the topology radio button is selected and vice versa.

Jira: https://issues.redhat.com/browse/CNV-45584

🎥 Demo

Before

updated-CPU-memory-modal--BEFORE--2024-08-28 08-45

After

updated-CPU-memory-modal--AFTER--2024-08-28 08-44

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avivtur and tnisan August 28, 2024 12:49
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Aug 28, 2024
@pcbailey pcbailey force-pushed the feature-update-cpu-memory-ui branch from a29e986 to b9d57ce Compare August 30, 2024 14:45
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 30, 2024

@pcbailey: This pull request references CNV-45584 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

This PR updates the behavior of the new CPU inputs so that the vCPU count changes when the topology inputs are changed and that the vCPU input is disabled when the topology radio button is selected and vice versa.

Jira: https://issues.redhat.com/browse/CNV-45584

🎥 Demo

Before

updated-CPU-memory-modal--BEFORE--2024-08-28 08-45

After

updated-CPU-memory-modal--AFTER-with-text-changes--2024-08-30 10-41

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pcbailey pcbailey changed the title WIP: CNV-45584: Fix new CPU inputs behavior in CPU/memory modal CNV-45584: Fix new CPU inputs behavior in CPU/memory modal Aug 30, 2024
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Aug 30, 2024
Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pcbailey,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9fdfc05 into kubevirt-ui:main Aug 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants