Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-47158: Fix upload PVC form unit selection #2145

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Aug 28, 2024

📝 Description

Fix upload PVC size unit select input

🎥 Demo

Before:

pvc-upload-form-b4.mp4

After:

pvc-upload-form-fixed.mp4

@openshift-ci openshift-ci bot requested review from metalice and pcbailey August 28, 2024 07:35
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Aug 28, 2024
@avivtur avivtur changed the title Fix upload PVC form unit selection CNV-47158: Fix upload PVC form unit selection Aug 28, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 28, 2024

@avivtur: This pull request references CNV-47158 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

Fix upload PVC size unit select input

🎥 Demo

Before:

pvc-upload-form-b4.mp4

After:

pvc-upload-form-fixed.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Aug 28, 2024
Copy link
Contributor

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit df1e43b into kubevirt-ui:main Aug 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants