Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-44365: add cluster -> overview to virtualization perspective #2143

Merged

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Aug 26, 2024

📝 Description

Adding the cluster -> overview in the virtualization perspective as a doc change

  • adding some data attributes to make the CSS works. (No className property)

Reduce padding for all the items and remove the border between them.
The last item Chekup does have borders so use a different class for that.
Add horizontal padding for the separator

https://docs.google.com/document/d/1_mv7aEDC2KiXv423CGPPnydu-WnF4zUP9xRbGjlcIIw/edit

🎥 Demo

Screenshot 2024-08-27 at 13 20 49

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 26, 2024

@upalatucci: This pull request references CNV-44365 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.17.0" instead.

In response to this:

📝 Description

Adding the cluster -> overview in the virtualization perspective as a doc change

https://docs.google.com/document/d/1_mv7aEDC2KiXv423CGPPnydu-WnF4zUP9xRbGjlcIIw/edit

🎥 Demo

Screenshot 2024-08-26 at 11 26 56

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from tnisan and vojtechszocs August 26, 2024 09:27
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Aug 26, 2024
@metalice
Copy link
Member

Hey @upalatucci didn't they wanted also to flat virtualization menu ?

@upalatucci upalatucci force-pushed the fix-virt-perspective branch from f853306 to 49dfdb1 Compare August 27, 2024 11:21
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 27, 2024

@upalatucci: This pull request references CNV-44365 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.17.0" instead.

In response to this:

📝 Description

Adding the cluster -> overview in the virtualization perspective as a doc change

  • adding some data attributes to make the CSS works. (No className property)

Reduce padding for all the items and remove the border between them.
The last item Chekup does have borders so use a different class for that.
Add horizontal padding for the separator

https://docs.google.com/document/d/1_mv7aEDC2KiXv423CGPPnydu-WnF4zUP9xRbGjlcIIw/edit

🎥 Demo

Screenshot 2024-08-27 at 13 20 49

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@upalatucci
Copy link
Member Author

@metalice fixed with the new design

@upalatucci
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Aug 29, 2024
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upalatucci
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit db96f5f into kubevirt-ui:main Aug 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants