-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-44365: add cluster -> overview to virtualization perspective #2143
CNV-44365: add cluster -> overview to virtualization perspective #2143
Conversation
@upalatucci: This pull request references CNV-44365 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.17.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hey @upalatucci didn't they wanted also to flat virtualization menu ? |
f853306
to
49dfdb1
Compare
@upalatucci: This pull request references CNV-44365 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.17.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@metalice fixed with the new design |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
📝 Description
Adding the cluster -> overview in the virtualization perspective as a doc change
Reduce padding for all the items and remove the border between them.
The last item Chekup does have borders so use a different class for that.
Add horizontal padding for the separator
https://docs.google.com/document/d/1_mv7aEDC2KiXv423CGPPnydu-WnF4zUP9xRbGjlcIIw/edit
🎥 Demo