Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-45584: Update Edit CPU | Memory modal UI #2131

Merged

Conversation

pcbailey
Copy link
Member

@pcbailey pcbailey commented Aug 17, 2024

📝 Description

This PR updates the design of the CPU/memory modal to give the user two methods for configuring the CPU: enter the CPU topology manually and entering the number of desired vCPUs.

Jira: https://issues.redhat.com/browse/CNV-45584

🎥 Screenshots

Before

cpu-mem-redesign--BEFORE--2024-08-16_22-24

After

cpu-mem-redesign--AFTER--2024-08-16_21-06

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 17, 2024

@pcbailey: This pull request references CNV-45584 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

This PR updates the design of the CPU/memory modal to give the user two methods for configuring the CPU: enter the CPU topology manually and entering the number of desired vCPUs.

Jira: https://issues.redhat.com/browse/CNV-45584

🎥 Demo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from metalice and tnisan August 17, 2024 02:07
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Aug 17, 2024
@pcbailey pcbailey changed the title WIP: CNV-45584: Update Edit CPU | Memory modal UI CNV-45584: Update Edit CPU | Memory modal UI Aug 17, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 17, 2024

@pcbailey: This pull request references CNV-45584 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

This PR updates the design of the CPU/memory modal to give the user two methods for configuring the CPU: enter the CPU topology manually and entering the number of desired vCPUs.

Jira: https://issues.redhat.com/browse/CNV-45584

🎥 Screenshots

Before

cpu-mem-redesign--BEFORE--2024-08-16_22-24

After

cpu-mem-redesign--AFTER--2024-08-16_21-06

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pcbailey pcbailey force-pushed the feature-change-edit-cpu-ui branch from 5ffde94 to d38eab5 Compare August 17, 2024 15:03
@pcbailey
Copy link
Member Author

/retest

1 similar comment
@pcbailey
Copy link
Member Author

/retest

Copy link
Member

@avivtur avivtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)
Left a few comments

@pcbailey pcbailey force-pushed the feature-change-edit-cpu-ui branch from d38eab5 to 3b7d6f8 Compare August 19, 2024 15:27
@pcbailey pcbailey force-pushed the feature-change-edit-cpu-ui branch from 3b7d6f8 to 4b46148 Compare August 19, 2024 15:33
@avivtur
Copy link
Member

avivtur commented Aug 20, 2024

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Aug 20, 2024
Copy link
Contributor

openshift-ci bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a54e81e into kubevirt-ui:main Aug 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants