-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-45584: Update Edit CPU | Memory modal UI #2131
CNV-45584: Update Edit CPU | Memory modal UI #2131
Conversation
@pcbailey: This pull request references CNV-45584 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@pcbailey: This pull request references CNV-45584 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
5ffde94
to
d38eab5
Compare
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work :)
Left a few comments
src/utils/components/CPUMemoryModal/components/CPUInput/CPUInput.tsx
Outdated
Show resolved
Hide resolved
src/utils/components/CPUMemoryModal/components/CPUInput/CPUInput.tsx
Outdated
Show resolved
Hide resolved
src/utils/components/CPUMemoryModal/components/CPUInput/CPUInput.tsx
Outdated
Show resolved
Hide resolved
...PUMemoryModal/components/CPUInput/components/CPUTopologyInput/components/CPUThreadsInput.tsx
Outdated
Show resolved
Hide resolved
...ryModal/components/CPUInput/components/vCPUInput/components/CPUHelperText/CPUHelperText.scss
Outdated
Show resolved
Hide resolved
d38eab5
to
3b7d6f8
Compare
3b7d6f8
to
4b46148
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
This PR updates the design of the CPU/memory modal to give the user two methods for configuring the CPU: enter the CPU topology manually and entering the number of desired vCPUs.
Jira: https://issues.redhat.com/browse/CNV-45584
🎥 Screenshots
Before
After