-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-43057: Auto register RHEL subscription and insights #2125
CNV-43057: Auto register RHEL subscription and insights #2125
Conversation
@metalice: This pull request references CNV-43057 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.17.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
b9ecc30
to
be36ed9
Compare
/retest |
subscriptionData.customUrl && | ||
subscriptionData.type !== AutomaticSubscriptionTypeEnum.ENABLE_PREDICTIVE_ANALYTICS | ||
) { | ||
subscriptionManagerCMD.push(`--serverurl=${subscriptionData.customUrl}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need a space before just like row 133?
Signed-off-by: Matan Schatzman <[email protected]>
be36ed9
to
be8c77a
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
Adding to cnv settings the subscription type,
No subscription - to registration to subscription-manager
Monitor and manage subscription - same as today once clicked apply
Enable predictive analytics - adding another command to runCmd to register insights
🎥 Demo