Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-43057: Auto register RHEL subscription and insights #2125

Conversation

metalice
Copy link
Member

📝 Description

Adding to cnv settings the subscription type,
No subscription - to registration to subscription-manager
Monitor and manage subscription - same as today once clicked apply
Enable predictive analytics - adding another command to runCmd to register insights

  • Replaced cloudconfig rh_subscrition with subscription-manager command

🎥 Demo

rhel-insight

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 13, 2024

@metalice: This pull request references CNV-43057 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.17.0" instead.

In response to this:

📝 Description

Adding to cnv settings the subscription type,
No subscription - to registration to subscription-manager
Monitor and manage subscription - same as today once clicked apply
Enable predictive analytics - adding another command to runCmd to register insights

  • Replaced cloudconfig rh_subscrition with subscription-manager command

🎥 Demo

rhel-insight

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avivtur and tnisan August 13, 2024 09:10
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Aug 13, 2024
@metalice metalice force-pushed the CNV-43057-auto-register-rhel-insight branch from b9ecc30 to be36ed9 Compare August 13, 2024 09:24
@metalice
Copy link
Member Author

/retest

subscriptionData.customUrl &&
subscriptionData.type !== AutomaticSubscriptionTypeEnum.ENABLE_PREDICTIVE_ANALYTICS
) {
subscriptionManagerCMD.push(`--serverurl=${subscriptionData.customUrl}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need a space before just like row 133?

@metalice metalice force-pushed the CNV-43057-auto-register-rhel-insight branch from be36ed9 to be8c77a Compare August 18, 2024 13:17
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Aug 18, 2024
Copy link
Contributor

openshift-ci bot commented Aug 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e9ae4b8 into kubevirt-ui:main Aug 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants