Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-44890: fix diskmodal issues #2115

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

upalatucci
Copy link
Member

📝 Description

BUgs when DataSources are connected to VolumeSnapshots instead of PVCs. We can't grab the PVC size because the chain is too long DS -> VS -> PVC . So just don't show the size.

When hotplugging something, the dataVolume needs to be created from dataVolumeTemplates. We cannot create it directly from the dataVolumeTemplates (doesn't have kind , apiVersion and namespace )

🎥 Demo

Before

no-disk-size-running-vm

Screenshot 2024-08-05 at 08 55 18

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 5, 2024

@upalatucci: This pull request references CNV-44890 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "CNV v4.17.0" instead.

In response to this:

📝 Description

BUgs when DataSources are connected to VolumeSnapshots instead of PVCs. We can't grab the PVC size because the chain is too long DS -> VS -> PVC . So just don't show the size.

When hotplugging something, the dataVolume needs to be created from dataVolumeTemplates. We cannot create it directly from the dataVolumeTemplates (doesn't have kind , apiVersion and namespace )

🎥 Demo

Before

no-disk-size-running-vm

Screenshot 2024-08-05 at 08 55 18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from metalice and tnisan August 5, 2024 07:20
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Aug 5, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Aug 5, 2024
@upalatucci
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Aug 6, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Aug 6, 2024
Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8ea6061 into kubevirt-ui:main Aug 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants