-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-44956: Adjusting storage checkups new fields #2100
CNV-44956: Adjusting storage checkups new fields #2100
Conversation
@metalice: This pull request references CNV-44956 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@@ -81,6 +84,14 @@ const CheckupsStorageDetailsPageSection: FC<CheckupsStorageDetailsPageSectionPro | |||
} | |||
descriptionHeader={t('Default storage class')} | |||
/> | |||
<VirtualMachineDescriptionItem | |||
descriptionData={configMap?.data?.[STORAGE_CHECKUPS_PVC_BOUND] || t('None')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t('None') in a const?
6438a4f
to
6d01d2f
Compare
Signed-off-by: Matan Schatzman <[email protected]>
6d01d2f
to
7dd4be0
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
📝 Description
Adjusting to new changes in BE for storage checkups according to https://github.com/kiagnose/kubevirt-storage-checkup?tab=readme-ov-file#checkup-results-retrieval
🎥 Demo