Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-44956: Adjusting storage checkups new fields #2100

Conversation

metalice
Copy link
Member

📝 Description

Adjusting to new changes in BE for storage checkups according to https://github.com/kiagnose/kubevirt-storage-checkup?tab=readme-ov-file#checkup-results-retrieval

🎥 Demo

image

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 31, 2024

@metalice: This pull request references CNV-44956 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

📝 Description

Adjusting to new changes in BE for storage checkups according to https://github.com/kiagnose/kubevirt-storage-checkup?tab=readme-ov-file#checkup-results-retrieval

🎥 Demo

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from tnisan and vojtechszocs July 31, 2024 07:37
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jul 31, 2024
@@ -81,6 +84,14 @@ const CheckupsStorageDetailsPageSection: FC<CheckupsStorageDetailsPageSectionPro
}
descriptionHeader={t('Default storage class')}
/>
<VirtualMachineDescriptionItem
descriptionData={configMap?.data?.[STORAGE_CHECKUPS_PVC_BOUND] || t('None')}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t('None') in a const?

@metalice metalice force-pushed the CNV-44956-adjusting-storage-checkups branch from 6438a4f to 6d01d2f Compare July 31, 2024 11:10
@metalice metalice force-pushed the CNV-44956-adjusting-storage-checkups branch from 6d01d2f to 7dd4be0 Compare July 31, 2024 11:12
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jul 31, 2024
Copy link
Contributor

openshift-ci bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metalice
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 891c169 into kubevirt-ui:main Jul 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants