CNV-43096: Customize disk size instancetype #2086
Conversation
|
@upalatucci: This pull request references CNV-43096 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "CNV v4.18.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
upalatucci
force-pushed
the
customize-disksize
branch
from
efb3778 to
bbb5bfc
Compare
...achines/details/tabs/configuration/storage/components/tables/disk/utils/getEditDiskStates.ts
Outdated
Show resolved
Hide resolved
upalatucci
force-pushed
the
customize-disksize
branch
from
bbb5bfc to
2e12275
Compare
upalatucci
force-pushed
the
customize-disksize
branch
2 times, most recently
from
6891b10 to
7619ffd
Compare
| <TabModal<V1VirtualMachine> | ||
| headerText={t('Detach disk?')} | ||
| isOpen={isOpen} | ||
| obj={vm} | ||
| onClose={onClose} | ||
| onSubmit={onCustomizeDeleteDisk} | ||
| submitBtnText={deleteBtnText} | ||
| submitBtnVariant={ButtonVariant.danger} | ||
| > | ||
| <ConfirmActionMessage action="detach" obj={{ metadata: { name: diskName } }} /> | ||
| </TabModal> |
upalatucci
force-pushed
the
customize-disksize
branch
from
7619ffd to
4c12feb
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
Change disk size in diskmodal option.
Only on customize flag true as it cannot be done on VMs already created
🎥 Demo
Before
After
Screen.Recording.2024-07-16.at.14.13.52.mov