Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs regarding running Console Bridge locally #2075

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

vojtechszocs
Copy link
Contributor

@vojtechszocs vojtechszocs commented Jul 4, 2024

📝 Description

When running Console Bridge locally,

-plugins kubevirt-plugin=http://localhost:9001/

(note the trailing slash) should be paired with

-i18n-namespaces=plugin__kubevirt-plugin

to ensure that the proper i18n namespace is registered for the plugin at Console runtime.

ℹ️ Note that .devcontainer/Dockerfile.console already contains

-i18n-namespaces $OC_PLUGIN_I18N_NAMESPACES

which could also be updated to

-i18n-namespaces plugin__$OC_PLUGIN_NAME

(and thus removing the need for OC_PLUGIN_I18N_NAMESPACES env variable) but I leave that up to you 😃

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jul 7, 2024
Copy link
Contributor

openshift-ci bot commented Jul 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jul 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e5b2fbb into kubevirt-ui:main Jul 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants