Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-43951: Upgrade Node version #2071

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

upalatucci
Copy link
Member

📝 Description

upgrade eslint-plugin-jsdoc to support node >= 18
Enforce node >= 18.x

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 3, 2024

@upalatucci: This pull request references CNV-43951 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "CNV v4.17.0" instead.

In response to this:

📝 Description

upgrade eslint-plugin-jsdoc to support node >= 18
Enforce node >= 18.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from hstastna and pcbailey July 3, 2024 08:54
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jul 3, 2024
@metalice
Copy link
Member

metalice commented Jul 3, 2024

i think the workflow and images should be updated to include node 18

@upalatucci
Copy link
Member Author

@metalice fixed

@metalice
Copy link
Member

metalice commented Jul 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jul 3, 2024
@upalatucci
Copy link
Member Author

/retest

5 similar comments
@upalatucci
Copy link
Member Author

/retest

@metalice
Copy link
Member

metalice commented Jul 7, 2024

/retest

@metalice
Copy link
Member

metalice commented Jul 8, 2024

/retest

@upalatucci
Copy link
Member Author

/retest

@metalice
Copy link
Member

metalice commented Jul 9, 2024

/retest

@metalice
Copy link
Member

/retest
@upalatucci if its not passing please try to fix

@metalice
Copy link
Member

@upalatucci
please replace those 3 lines in package.json and see if its passing

"test-cypress": "cd cypress && npx cypress open --config-file ./cypress.json --env openshift=true", "test-cypress-docker": "echo 'visit http://localhost:10000' && cd cypress && DISPLAY=:14 LIBGL_ALWAYS_INDIRECT=0 npx cypress open --config-file ./cypress.json --env openshift=true", "test-cypress-headless": "cd cypress && npx --max-old-space-size=4096 cypress run --config-file ./cypress.json --env openshift=true --headless",

@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Jul 22, 2024
removed engine, will be added in a followup pr
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jul 22, 2024
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ec33e37 into kubevirt-ui:main Jul 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants