-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-43951: Upgrade Node version #2071
CNV-43951: Upgrade Node version #2071
Conversation
@upalatucci: This pull request references CNV-43951 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "CNV v4.17.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
7b21fc9
to
71630d9
Compare
i think the workflow and images should be updated to include node 18 |
71630d9
to
a90fa2a
Compare
@metalice fixed |
/lgtm |
/retest |
5 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
@upalatucci
|
a90fa2a
to
7f20977
Compare
removed engine, will be added in a followup pr
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
upgrade eslint-plugin-jsdoc to support node >= 18
Enforce node >= 18.x