Move disk source outside the add disk modal dialog #2061
Conversation
src/utils/components/DiskSourceFlyoutMenu/DiskSourceFlyoutMenu.tsx
Outdated
Show resolved
Hide resolved
src/utils/components/DiskSourceFlyoutMenu/DiskSourceFlyoutMenu.tsx
Outdated
Show resolved
Hide resolved
| <MenuContent> | ||
| <MenuList> | ||
| {options?.map(({ description, groupLabel, items }) => { | ||
| const isFlyout = items?.length > 1; |
There was a problem hiding this comment.
I can do this, I thought it would be more readable like this when the condition has context to it
| </Menu> | ||
| ); | ||
|
|
||
| return ( |
There was a problem hiding this comment.
i understand why menu and toggle are here, as nested components, as they are deeply coupled, but still consider exporting them to new files and giving them the right Capital naming.
There was a problem hiding this comment.
Extracting those to separated components is not working well for the MenuContainer as it expects a ReactElement type which have children:
avivtur
force-pushed
the
move-disk-source
branch
from
c5645b4 to
d697000
Compare
Signed-off-by: Aviv Turgeman <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
Changing the
Add diskbutton to a flyout-dropdown to select the disk source from outside the add disk dialog.🎥 Demo
After:
reorganize-disk-modal.mp4