CNV-43091: Remove restart required msg from affinity and node selector #2047
Conversation
Signed-off-by: Matan Schatzman <[email protected]>
|
@metalice: This pull request references CNV-43091 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
I think here we need to completely remove the affinity and node selector references from this function.
We don't need to check with getChangedAffinity and getChangedNodeSelector if there are discrepancies between VM and vmi for that right?
There was a problem hiding this comment.
I left it because of a situation where the machine isn't live migratable, so it still shows a message of pending changes. However, we won't show it in most cases, so I removed it from the main modal. In most cases, it's not relevant anymore, but in the some cases, it is applicable, so the pending changes in the global VM details message will cover it.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.16 |
|
@gouyang: new pull request created: #2123 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 Description
I am removing the restart required message from the affinity and node selector models as they are now live update, and no restart is needed if they are live migratable.
🎥 Demo
After:
Before:
