Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-43120: sysprep or sshcredentials in zustand #2046

Merged

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Jun 18, 2024

📝 Description

We can only have sysprep or ssh credentials. Not both. If the user change bootable volume, he can select both of them in the zustand state and produce some issues

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 18, 2024

@upalatucci: This pull request references CNV-43120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

…state

📝 Description

We can only have sysprep or ssh credentials. Not both. If the user change bootable volume, he can select both of them in the zustand state and produce some issues

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from metalice and vojtechszocs June 18, 2024 13:31
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jun 18, 2024
@upalatucci upalatucci changed the title CNV-43120: select sysprep remove ssh credentials config from zustand … CNV-43120: sysprep or sshcredentials in zustand Jun 18, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 18, 2024

@upalatucci: This pull request references CNV-43120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

📝 Description

We can only have sysprep or ssh credentials. Not both. If the user change bootable volume, he can select both of them in the zustand state and produce some issues

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 18, 2024
Copy link
Contributor

openshift-ci bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c39cfc7 into kubevirt-ui:main Jun 18, 2024
10 checks passed
@gouyang
Copy link
Member

gouyang commented Jun 19, 2024

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link
Collaborator

@gouyang: new pull request created: #2048

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants