Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-41832: Hide Access/Volume Mode radio buttons when optimized storage profile … #2044

Conversation

pcbailey
Copy link
Member

📝 Description

This PR simplifies hiding the Access and Volume mode radio button groups when the "Apply optimized StorageProfile settings" checkbox is checked. This PR will be backported to 4.15 where the radio button groups are currently not being hidden when the checkbox is checked.

Jira: https://issues.redhat.com/browse/CNV-41832

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 18, 2024

@pcbailey: This pull request references CNV-41832 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

📝 Description

This PR simplifies hiding the Access and Volume mode radio button groups when the "Apply optimized StorageProfile settings" checkbox is checked. This PR will be backported to 4.15 where the radio button groups are currently not being hidden when the checkbox is checked.

Jira: https://issues.redhat.com/browse/CNV-41832

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avivtur and metalice June 18, 2024 00:41
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jun 18, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 18, 2024
Copy link
Contributor

openshift-ci bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pcbailey,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit db840c7 into kubevirt-ui:main Jun 18, 2024
10 checks passed
@pcbailey
Copy link
Member Author

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link
Collaborator

@pcbailey: new pull request created: #2051

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants