Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-41586: Missing functions for sysprep customizr IT flow #1997

Conversation

metalice
Copy link
Member

@metalice metalice commented Jun 4, 2024

📝 Description

Fix customize IT flow sysprep - missing functions

🎥 Demo

Please add a video or an image of the behavior/changes

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 4, 2024

@metalice: This pull request references CNV-41586 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

📝 Description

Fix customize IT flow sysprep - missing functions

🎥 Demo

Please add a video or an image of the behavior/changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from upalatucci and vojtechszocs June 4, 2024 06:21
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jun 4, 2024
@@ -19,3 +19,9 @@ export const getCustomizeInstanceTypeSessionStorage = (): V1VirtualMachine => {
}
return null;
};

export const mergeData = (seedData, appendData) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add types here?

Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

@metalice: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metalice
Copy link
Member Author

metalice commented Jun 4, 2024

/retest

@avivtur
Copy link
Member

avivtur commented Jun 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 5, 2024
Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gouyang
Copy link
Member

gouyang commented Jun 5, 2024

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link
Collaborator

@gouyang: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit a62868d into kubevirt-ui:main Jun 5, 2024
10 checks passed
@openshift-cherrypick-robot
Copy link
Collaborator

@gouyang: new pull request created: #2001

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants