CNV-42157: Fix disk modal template #1977
Conversation
upalatucci
changed the title
|
@upalatucci: This pull request references CNV-42157 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -43,13 +41,6 @@ import { DYNAMIC } from '../components/utils/constants'; | |||
| import { getInitialStateDiskForm, mapSourceTypeToVolumeType } from './constants'; | |||
| import { DiskFormState, DiskModalProps, SourceTypes, VolumeTypes } from './types'; | |||
|
|
|||
| const nameWithoutParameter = (name: string, defaultValue?) => { | |||
There was a problem hiding this comment.
why we used it in the first place?
There was a problem hiding this comment.
Me and aviv have no idea.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.16 |
|
@gouyang: new pull request created: #2013 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 Description