Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-40336: Revert "CNV-35287: Prevent VM Migration charts to show the sum of values #1972

Merged

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented May 23, 2024

This reverts commit 77d198d.

📝 Description

Talking to shirly she says that those are the right queries :https://issues.redhat.com/browse/CNV-37525

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 23, 2024

@upalatucci: This pull request references CNV-35287 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "CNV v4.17.0" instead.

In response to this:

…ues"

This reverts commit 77d198d.

📝 Description

Talking to shirly she says that those are the right queries :https://issues.redhat.com/browse/CNV-37525

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avivtur and yaacov May 23, 2024 13:16
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 23, 2024
@upalatucci upalatucci changed the title Revert "CNV-35287: Prevent VM Migration charts to show the sum of val… CNV-40336: Revert "CNV-35287: Prevent VM Migration charts to show the sum of val… May 23, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 23, 2024

@upalatucci: This pull request references CNV-40336 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

…ues"

This reverts commit 77d198d.

📝 Description

Talking to shirly she says that those are the right queries :https://issues.redhat.com/browse/CNV-37525

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@upalatucci upalatucci changed the title CNV-40336: Revert "CNV-35287: Prevent VM Migration charts to show the sum of val… CNV-40336: Revert "CNV-35287: Prevent VM Migration charts to show the sum of values May 23, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 23, 2024

@upalatucci: This pull request references CNV-40336 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

This reverts commit 77d198d.

📝 Description

Talking to shirly she says that those are the right queries :https://issues.redhat.com/browse/CNV-37525

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 26, 2024
Copy link
Contributor

openshift-ci bot commented May 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 76da801 into kubevirt-ui:main May 26, 2024
10 checks passed
@upalatucci
Copy link
Member Author

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link
Collaborator

@upalatucci: new pull request created: #1982

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants