CNV-39940: UI does not show installed version #1968
Conversation
|
@avivtur: This pull request references CNV-39940 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| }); | ||
|
|
||
| const subscription = useMemo( | ||
| () => subscriptions?.find((sub) => sub?.spec?.name === KUBEVIRT_HYPERCONVERGED), |
There was a problem hiding this comment.
community-kubevirt-hyperconverged in case of isUpstream == true
There was a problem hiding this comment.
@orenc1 I changed it to check if the string ends with "kubevirt-hyperconverged" to cover both cases , sounds ok with you?
There was a problem hiding this comment.
yes, that will work either 👍
Signed-off-by: Aviv Turgeman <[email protected]>
|
@avivtur: This pull request references CNV-39940 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
avivtur
force-pushed
the
version-keeps-loading
branch
from
bba1b8c to
b40e6e4
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, hstastna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.16 |
|
/cherry-pick release-4.15 |
|
@gouyang: new pull request created: #1973 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@gouyang: new pull request created: #1974 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 Description
The UI assumes that the subscription that holds the version metadata has a unique name.
Since the name of the subscription CR is arbitrary, we now check if the subscription is from the package of
kubevirt-hyperconvergedor in some community upstream cases the package namedcommunity-kubevirt-hyperconverged.🎥 Demo
Before:
After:
