CNV-41844: Improve displaying sysprep section when creating Windows VMs #1956
Conversation
|
@hstastna: This pull request references CNV-41844 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@hstastna: This pull request references CNV-41844 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Improve sysprep section in InstanceTypes tab while using existing sysprep: display ConfigMap name in one line with the used pencil icon, omit unnecessary "Selected sysprep" string in this section. Fixes https://issues.redhat.com/browse/CNV-41844
hstastna
force-pushed
the
BZ_Improve_sysprep_section
branch
from
229f23c to
a4cf536
Compare
|
@hstastna: This pull request references CNV-41844 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@avivtur @pcbailey @upalatucci @metalice please review |
| moreInfoURL={moreInfoURL} | ||
| /> | ||
| </FlexItem> | ||
| {(bodyContent || breadcrumb || descriptionHeader || label || moreInfoURL) && ( |
There was a problem hiding this comment.
can u please explain the condition seems a bit strange the || between hard values
There was a problem hiding this comment.
We don't want to render the header if none of these props are defined.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.16 |
|
@gouyang: new pull request created: #2018 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 Description
Fixes:
https://issues.redhat.com/browse/CNV-41844
Improve sysprep section in InstanceTypes tab while using existing sysprep: display ConfigMap name in one line with the used
Pencilicon, omit unnecessary Selected sysprep string in this section.🎥 Screenshots
Before:
Not as nicely readable Sysprep section:
After:
