Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-41689: Fix fetching for all namespaces on user instance types #1944

Conversation

metalice
Copy link
Member

📝 Description

Instancetype hook didn't fetch for all namespaces, added arg to hook to bypass if needed.

🎥 Demo

After:

image

Before:

image

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 15, 2024

@metalice: This pull request references CNV-41689 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Instancetype hook didn't fetch for all namespaces, added arg to hook to bypass if needed.

🎥 Demo

After:

image

Before:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from tnisan and vojtechszocs May 15, 2024 05:16
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 15, 2024
@metalice metalice force-pushed the CNV-41689-all-projects-user-instance-types branch from 9e87171 to 70efdfc Compare May 19, 2024 04:44
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 20, 2024
Copy link
Contributor

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metalice
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 4271280 into kubevirt-ui:main May 21, 2024
10 checks passed
@upalatucci
Copy link
Member

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link
Collaborator

@upalatucci: new pull request created: #2254

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants