Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add request timeout options #27

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

Somefive
Copy link
Contributor

Signed-off-by: Yin Da [email protected]

Example: setting --request-timeout=5s will enforce a timeout of 5s for each resource API call.

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 83.07% // Head: 83.51% // Increases project coverage by +0.43% 🎉

Coverage data is based on head (faad0de) compared to base (c3c6d99).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   83.07%   83.51%   +0.43%     
==========================================
  Files          32       33       +1     
  Lines         721      740      +19     
==========================================
+ Hits          599      618      +19     
  Misses         85       85              
  Partials       37       37              
Flag Coverage Δ
unit-test 83.51% <100.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/apiserver/options/server_run_options.go 100.00% <100.00%> (ø)
pkg/apis/cluster/v1alpha1/config.go 0.00% <0.00%> (ø)
pkg/apis/cluster/v1alpha1/reader.go 100.00% <0.00%> (ø)
pkg/apis/o11y/grafana/v1alpha1/conversion.go 100.00% <0.00%> (ø)
pkg/apis/cluster/v1alpha1/client.go 80.00% <0.00%> (+1.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive merged commit 6a25625 into kubevela:master Oct 21, 2022
@Somefive Somefive deleted the feat/add-request-timeout-options branch October 21, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant