Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support cluster control plane label #24

Merged

Conversation

Somefive
Copy link
Contributor

Signed-off-by: Yin Da [email protected]

Support cluster.core.oam.dev/control-plane label for all clusters. This label is added in logic label, but can be seen and selected.

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 83.07% // Head: 83.31% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (0b780bc) compared to base (c3c6d99).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   83.07%   83.31%   +0.23%     
==========================================
  Files          32       32              
  Lines         721      725       +4     
==========================================
+ Hits          599      604       +5     
+ Misses         85       84       -1     
  Partials       37       37              
Flag Coverage Δ
unit-test 83.31% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apis/cluster/v1alpha1/config.go 0.00% <ø> (ø)
pkg/apis/cluster/v1alpha1/client.go 79.68% <100.00%> (+1.35%) ⬆️
pkg/apis/cluster/v1alpha1/reader.go 100.00% <100.00%> (ø)
pkg/util/singleton/client.go 23.07% <0.00%> (+1.64%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive merged commit c752b9d into kubevela:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant