Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: delete id for dashboard request #21

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

Somefive
Copy link
Contributor

Signed-off-by: Yin Da [email protected]

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #21 (245a784) into master (6268967) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   83.05%   83.07%   +0.02%     
==========================================
  Files          32       32              
  Lines         720      721       +1     
==========================================
+ Hits          598      599       +1     
  Misses         85       85              
  Partials       37       37              
Flag Coverage Δ
unit-test 83.07% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apis/o11y/grafana/v1alpha1/printer.go 87.50% <ø> (ø)
.../apis/o11y/grafanadashboard/v1alpha1/conversion.go 92.45% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6268967...245a784. Read the comment docs.

@Somefive Somefive merged commit c3c6d99 into kubevela:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant