Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: filter out OCM ManagedCluster underlying secret #17

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

Somefive
Copy link
Contributor

Signed-off-by: Yin Da [email protected]

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #17 (15fe69a) into master (27c9883) will decrease coverage by 0.09%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   80.68%   80.59%   -0.10%     
==========================================
  Files          12       12              
  Lines         233      237       +4     
==========================================
+ Hits          188      191       +3     
- Misses         33       34       +1     
  Partials       12       12              
Flag Coverage Δ
unit-test 80.59% <85.71%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apis/cluster/v1alpha1/errors.go 62.50% <75.00%> (-4.17%) ⬇️
pkg/apis/cluster/v1alpha1/reader.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27c9883...15fe69a. Read the comment docs.

@Somefive Somefive force-pushed the fix/support-ocm-cluster-secret branch from cf69386 to 15fe69a Compare June 13, 2022 12:25
@Somefive Somefive merged commit 94f1190 into kubevela:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant