Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop SeccompProfile from populator pod #211

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

liranr23
Copy link
Member

@liranr23 liranr23 commented Mar 9, 2023

Having the SeccompProfile set to runtime caused an issue starting the pod with the error:

E0308 21:59:06.167954 1 controller.go:418] error syncing 'pvc/arik/2d096ab7-44fa-4935-b0d0-333532e84e5f': pods "populate-f4436d1b-2075-4a51-b6a1-3b1d72e29cde" is forbidden: unable to validate against any security context constraint: [pod.metadata.annotations[[container.seccomp.security.alpha.kubernetes.io/populate](http://container.seccomp.security.alpha.kubernetes.io/populate)]: Forbidden: seccomp may not be set, provider "containerized-data-importer": Forbidden: not usable by user or serviceaccount, provider restricted-v2: .spec.securityContext.fsGroup: Invalid value: []int64{107}: 107 is not an allowed group, spec.containers[0].securityContext.runAsUser: Invalid value: 107: must be in the ranges: [1000700000, 1000709999], provider "restricted": Forbidden: not usable by user or serviceaccount, provider "nonroot-v2": Forbidden: not usable by user or serviceaccount, provider "nonroot": Forbidden: not usable by user or serviceaccount, provider "hostmount-anyuid": Forbidden: not usable by user or serviceaccount, provider "kubevirt-controller": Forbidden: not usable b...
That came from PR #189 and relates to openshift/cluster-kube-apiserver-operator#1325

Having the SeccompProfile set to runtime caused an issue starting the
pod.

Signed-off-by: Liran Rotenberg <[email protected]>
@liranr23 liranr23 requested a review from ahadas as a code owner March 9, 2023 09:36
@liranr23 liranr23 requested a review from bennyz March 9, 2023 09:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.0% 6.0% Duplication

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -3.40 ⚠️

Comparison is base (8f64ee6) 33.94% compared to head (ad79a17) 30.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   33.94%   30.55%   -3.40%     
==========================================
  Files          43       45       +2     
  Lines        8112     9250    +1138     
==========================================
+ Hits         2754     2826      +72     
- Misses       5141     6201    +1060     
- Partials      217      223       +6     
Flag Coverage Δ
unittests 30.55% <ø> (-3.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...m/kubev2v/forklift/pkg/controller/plan/kubevirt.go 0.00% <0.00%> (ø)
.../kubev2v/forklift/pkg/controller/plan/migration.go 0.00% <0.00%> (ø)
...volume-populator/populator-machinery/controller.go 0.00% <0.00%> (ø)
...ib-volume-populator/populator-machinery/metrics.go 73.46% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@liranr23 liranr23 merged commit 51e1686 into kubev2v:main Mar 9, 2023
@liranr23 liranr23 deleted the populator_sec branch March 9, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants