Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(): add default slice support #232

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

feat(): add default slice support #232

wants to merge 17 commits into from
+811 −295

Conversation

RohanKumarMainali
Copy link
Member

@RohanKumarMainali RohanKumarMainali commented Nov 27, 2024 •
edited
Loading

Description

This PR contain changes to introduce default slice. If defaultSliceCreation is enabled in project CR,a slice with projectName-default-slice gets created that will contain all the namespaces of worker clusters attached to that particular project which are currently not attached to any slice.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit test cases.

Does this PR introduce a breaking change for other components like worker-operator?

RohanKumarMainali and others added 17 commits November 27, 2024 17:03
@RohanKumarMainali
fix(): add default slice creation flag in project
449369d 
Signed-off-by: RohanKumarMainali <[email protected]>
@priyank-upadhyay @RohanKumarMainali
fix(): create bases
d0e4959 
Signed-off-by: Priyank Upadhyay <[email protected]>
@RohanKumarMainali
feat(): add default slice creation
f23deec 
Signed-off-by: RohanKumarMainali <[email protected]>
@RohanKumarMainali
fix(): debug logs
455568f 
Signed-off-by: RohanKumarMainali <[email protected]>
@RohanKumarMainali
fix(): change controller-gen version
5880b4f 
Signed-off-by: RohanKumarMainali <[email protected]>
@RohanKumarMainali
fix(): handle ns addition and removal
170a9cf 
Signed-off-by: RohanKumarMainali <[email protected]>
@RohanKumarMainali
fix(): handle namespace removal
0f7590e 
Signed-off-by: RohanKumarMainali <[email protected]>
@RohanKumarMainali
feat(): filter defaultsliceconfig appns
caf2a30 
Signed-off-by: RohanKumarMainali <[email protected]>
@RohanKumarMainali
fix(): refactor code
3791954 
Signed-off-by: RohanKumarMainali <[email protected]>
@RohanKumarMainali
fix(): move default-slice-creation logic to project
1fb4213 
Signed-off-by: RohanKumarMainali <[email protected]>
@RohanKumarMainali
fix(): revert slice creation to cluster
ab58c19 
Signed-off-by: RohanKumarMainali <[email protected]>
@RohanKumarMainali
fix(): add webhook validation for default slice edit
3585419 
Signed-off-by: RohanKumarMainali <[email protected]>
@RohanKumarMainali
fix(): avoid multiple cluster reconciliation
8a76af8 
Signed-off-by: RohanKumarMainali <[email protected]>
@RohanKumarMainali
fix(): deregister cluster from defaultsliceconfig during deletion
a18c58c 
Signed-off-by: RohanKumarMainali <[email protected]>
@RohanKumarMainali
fix(): add check for deregisterInProgress
8c51b23 
Signed-off-by: RohanKumarMainali <[email protected]>
@RohanKumarMainali
fix(): cleanup for project and refactor code
d3f8bf3 
Signed-off-by: RohanKumarMainali <[email protected]>
@RohanKumarMainali
fix(): fix slice and cluster UTs and increate maxCluster to 32
7543933 
Signed-off-by: RohanKumarMainali <[email protected]>
@RohanKumarMainali RohanKumarMainali marked this pull request as ready for review November 27, 2024 11:36
@RohanKumarMainali RohanKumarMainali changed the title Feature default slice support feat(): add default slice support Nov 27, 2024
@RohanKumarMainali RohanKumarMainali changed the base branch from feature-default-slice to master November 27, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narmidm narmidm Awaiting requested review from narmidm narmidm is a code owner

@priyank-upadhyay priyank-upadhyay Awaiting requested review from priyank-upadhyay priyank-upadhyay is a code owner

@that-backend-guy that-backend-guy Awaiting requested review from that-backend-guy that-backend-guy is a code owner

@bharath-avesha bharath-avesha Awaiting requested review from bharath-avesha

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RohanKumarMainali @priyank-upadhyay