Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): tcp support #31

Merged
merged 4 commits into from
Oct 31, 2023
Merged

fix(): tcp support #31

merged 4 commits into from
Oct 31, 2023

Conversation

narmidm
Copy link
Member

@narmidm narmidm commented Oct 30, 2023

Description

Adding TCP support for slice Gateway. changes done for gateway cert manager.

Fixes

ovpn/scripts/validate.sh
This code first checks if GATEWAY_PROTOCOL is missing or empty and sets GATEWAY_PROTOCOL to "udp" in that case. If GATEWAY_PROTOCOL is set, it converts it to lowercase using the tr command and then checks if it's not "udp" or "tcp" and sets it to "udp" in that case.

ovpn/template/client-openvpn-combined.conf
ovpn/template/server-openvpn.conf

new configuration added - proto

ovpn/scripts/process.sh
replace the value of from job env value ${GATEWAY_PROTOCOL}.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • manual testing with using the build image from Jenkins

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit test cases.

Does this PR introduce a breaking change for other components like kubeslice-controller, worker-operator?


@narmidm narmidm closed this Oct 31, 2023
@narmidm narmidm reopened this Oct 31, 2023
@narmidm narmidm self-assigned this Oct 31, 2023
Copy link

@mridulgain mridulgain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK

@narmidm narmidm merged commit f96480a into master Oct 31, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants