Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couldn't find helm binary when installing Testkube components #1309

Closed
mgoodwin1989 opened this issue Apr 16, 2022 · 6 comments · Fixed by #1377
Closed

Couldn't find helm binary when installing Testkube components #1309

mgoodwin1989 opened this issue Apr 16, 2022 · 6 comments · Fixed by #1377
Assignees
Labels
bug 🐛 Something is not working as should be

Comments

@mgoodwin1989
Copy link
Contributor

**I followed the Testkube plugin installation instruction and there is no mention of helm needing to be installed but when I tried to install the Testkube components using command kubectl testkube install I got the following error:

To Reproduce
Steps to reproduce the behavior:

  1. Run kubectl testkube install
  2. See error 'Installing testkube (error: exec: "helm": executable file not found in $PATH)'**

Expected behavior
Teskube components would be installed in the Kubenetes cluster

Version / Cluster

  • Testkube version - 1.0.3
  • Kubernetes cluster - Minikube
  • Kubernetes version - 1.25.2
@mgoodwin1989 mgoodwin1989 added the bug 🐛 Something is not working as should be label Apr 16, 2022
mgoodwin1989 added a commit to mgoodwin1989/testkube that referenced this issue Apr 16, 2022
Updating documentation will resolve issue kubeshop#1309
@TheBrunoLopes
Copy link
Collaborator

@kubeshop/testkube Would it be possible to install helm in case it's not installed ? Either Way, probably worth to add helm as a requirement in our docs.

@vsukhin
Copy link
Collaborator

vsukhin commented Apr 18, 2022

@bioslikk docs were update there #1310, not sure about helm installation, because it's beyond testkube scope

@dimonlex
Copy link
Contributor

Thanks for pointing it out @mgoodwin1989. Are you all set otherwise?

@mgoodwin1989
Copy link
Contributor Author

mgoodwin1989 commented Apr 18, 2022 via email

@exu
Copy link
Member

exu commented Apr 19, 2022

I assume that we could use helm api from some kind of helm go library? For sure it would need to be researched but should be possible- we would get rid of helm binary dependency then. @vsukhin @nicufk @vLia what do you think?

Helm is doing quite a lot in e.g. install cmd https://github.com/helm/helm/blob/v3.8.2/cmd/helm/install.go

@vsukhin
Copy link
Collaborator

vsukhin commented Apr 19, 2022

yes, helm 3 has go sdk. so, technically we can have a deep integraion with helm if we want, but it also means that testkube will contain helm inside, even if most of the users will already have helm installed. For me, it's really questionable, depending if users have real demand for this

@kubeshop kubeshop locked and limited conversation to collaborators Apr 25, 2022
@exu exu converted this issue into discussion #1378 Apr 25, 2022
@exu exu self-assigned this Apr 26, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
bug 🐛 Something is not working as should be
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants