Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default chart settings (node SBOM,mTLS, Admission controller, and HTTP) #625

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

slashben
Copy link
Contributor

This pull request includes major changes to the kubescape-operator Helm charts to change default configuration options and enable additional security capability. The most important changes include enabling certain features by default, modifying conditions for enabling HTTP visiblity, and enabling mTLS for storage.

Configuration enhancements:

Default capability changes:

Security improvements:

@slashben slashben requested a review from matthyx February 25, 2025 09:12
Copy link

gitguardian bot commented Feb 25, 2025

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
15748363 Triggered RSA Private Key f56dbae charts/kubescape-operator/tests/snapshot/snapshot_test.yaml.snap View secret
15748364 Triggered RSA Private Key f56dbae charts/kubescape-operator/tests/snapshot/snapshot_test.yaml.snap View secret
15748336 Triggered RSA Private Key c48f541 charts/kubescape-operator/tests/snapshot/snapshot_test.yaml.snap View secret
15748365 Triggered RSA Private Key f56dbae charts/kubescape-operator/tests/snapshot/snapshot_test.yaml.snap View secret
15748366 Triggered RSA Private Key f56dbae charts/kubescape-operator/tests/snapshot/snapshot_test.yaml.snap View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

@matthyx matthyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will definitely update the minor version for this one

@matthyx
Copy link
Contributor

matthyx commented Feb 25, 2025

@slashben looks like the cert generation if failing the unit test - can we pin the randomness?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants