Kubero V3 refactoring

[mms-gianni]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Template (non-breaking change which adds a template)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• I've built the image and tested it on a kubernetes cluster

Test Configuration:

• Operator Version:
• Kubernetes Version:
• Kubero CLI Version (if applicable):

Checklist:

• I removed unnecessary debug logs
• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I documented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[mms-gianni]

Progress

To fix the problem, we need to ensure that the stack trace and any sensitive information contained in the error object are not exposed to the end user. Instead, we should log the error details on the server and send a generic error message to the user. This can be achieved by modifying the catch block to log the error and send a generic message.

To fix the problem, we need to ensure that the error message is properly sanitized or escaped before being sent in the response. This can be achieved by using a library like he (HTML entities) to escape the error message. This will prevent any malicious content from being interpreted as HTML.

1. Install the he library to handle HTML escaping.
2. Import the he library in the templates.controller.ts file.
3. Use the he.escape function to escape the error message before sending it in the response.

To fix the problem, we need to replace the current password hashing mechanism with a more secure one, such as bcrypt. This will ensure that the password hashing process is computationally intensive, making it more resistant to brute-force attacks.

1. Install the bcrypt library if it is not already installed.
2. Import the bcrypt library in the auth.service.ts file.
3. Replace the existing SHA-256 hashing code with bcrypt hashing.
4. Update the password comparison logic to use bcrypt's comparison function.

To fix the SSRF vulnerability, we need to validate and restrict the user input to ensure it only allows safe and intended URLs. One way to achieve this is by using an allow-list of trusted base64 encoded URLs. This approach ensures that only predefined and safe URLs can be used in the axios.get request.

1. Create an allow-list of trusted base64 encoded URLs.
2. Validate the templateB64 parameter against this allow-list before decoding and using it in the request.
3. If the templateB64 parameter is not in the allow-list, throw an error.

To fix the problem, we should replace the use of crypto.createHmac('sha256', ...) with a more secure password hashing scheme such as bcrypt. This will ensure that the password hashing process requires significant computational effort, making it more resistant to brute-force attacks.

The best way to fix the problem without changing existing functionality is to use the bcrypt library to hash the passwords. We will need to import the bcrypt library, update the password hashing logic to use bcrypt.hashSync, and ensure that the salt is properly generated and used.