Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update list of sig-docs-pr-reviewers #9249

Merged
merged 3 commits into from
Jul 13, 2018
Merged

Update list of sig-docs-pr-reviewers #9249

merged 3 commits into from
Jul 13, 2018

Conversation

zacharysarah
Copy link
Contributor

This PR freshens OWNERS_ALIASES with a current list of contributors for @kubernetes/sig-docs-pr-reviews.

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2018
@zacharysarah zacharysarah added Needs Docs Review and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jun 26, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8ca8fd9

https://deploy-preview-9249--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit e6b068f

https://deploy-preview-9249--kubernetes-io-master-staging.netlify.com

@heckj
Copy link
Contributor

heckj commented Jun 26, 2018

👍

@steveperry-53
Copy link
Contributor

steveperry-53 commented Jun 26, 2018 •
edited
Loading

@zacharysarah This looks good to me. I think we should probably not have two things with almost the same name:

  • sig-docs-pr-reviewers, which you have edited in this PR
  • sig-docs-pr-reviews, a GitHub team

Maybe we don't need the GitHub team any more.

Oh wait, the list that you edited isn't sig-docs-pr-reviewers. It is sig-docs-pr-reviews. So now I'm confused. Is there a relationship between the list in this PR and the GitHub team?

@zacharysarah
Copy link
Contributor Author

@steveperry-53

Is there a relationship between the list in this PR and the GitHub team?

The alias block for SIG Docs follows the same format as other teams, so my guess is that the team is required for flagging SIG Docs for PR reviews across the org.

This PR syncs the contents of OWNERS_ALIAS with membership in the GH team.

@stewart-yu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 11, 2018
@zacharysarah
Copy link
Contributor Author

/assign @zparnold PTAL

@k8s-ci-robot
Copy link
Contributor

@zacharysarah: GitHub didn't allow me to assign the following users: PTAL.

Note that only kubernetes members and repo collaborators can be assigned.

In response to this:

/assign @zparnold PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdlinville
Copy link
Contributor

/assign @zparnold

@zparnold
Copy link
Member

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2018
@zparnold
Copy link
Member

@zacharysarah I see a few people in here that aren't in the OWNER_ALIASES file: https://github.com/orgs/kubernetes/teams/sig-docs-pr-reviews/members

Wasn't sure if that's intentional. I'll wait to approve until then. 😄

@zparnold
Copy link
Member

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2018
@zacharysarah
Copy link
Contributor Author

@zparnold Good catch--I updated both the team and this PR, so it should be ready to go now.

@zparnold
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8315bd0 into kubernetes:master Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@zparnold zparnold

@stewart-yu stewart-yu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zacharysarah @k8sio-netlify-preview-bot @heckj @steveperry-53 @stewart-yu @k8s-ci-robot @mdlinville @zparnold