Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions for staging site using Docker #9217

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Add instructions for staging site using Docker #9217

merged 2 commits into from
Aug 22, 2018

Conversation

tfogo
Copy link
Contributor

@tfogo tfogo commented Jun 25, 2018

Adds a condensed version of the Docker instructions in the README to the Create a PR doc page.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 25, 2018
@tfogo
Copy link
Contributor Author

tfogo commented Jun 25, 2018

/hold
The instructions depend on #9216 as they use make docker-serve instead of make stage.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2018
@tfogo
Copy link
Contributor Author

tfogo commented Jun 25, 2018

/assign @bradtopol

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b5b4af0

https://deploy-preview-9217--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jun 25, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1826813

https://deploy-preview-9217--kubernetes-io-master-staging.netlify.com

@tfogo
Copy link
Contributor Author

tfogo commented Jul 27, 2018

/hold cancel
#9216 has now been merged so these instructions are now correct. I probably should have included these changes in #9216 but I forgot I had this PR open. 😅

@bradtopol could you please take a look? Thanks 😀

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2018
@tfogo
Add instructions for staging site using Docker
168966d 
Adds a condensed version of the instructions in the README to
the intermediate contribution page.
@tfogo tfogo force-pushed the tf-docker-stage-instructions branch from b5b4af0 to 168966d Compare August 7, 2018 20:33
@tfogo
Copy link
Contributor Author

tfogo commented Aug 7, 2018

#9510 refactored the contributor guide. I rebased and added the docker instructions to the new guide.

@zacharysarah
Copy link
Contributor

@tfogo 👋 Thanks for your patience.

@lucperkins Would you mind reviewing this, please? Thanks in advance! 🙇

@lucperkins
Copy link
Contributor

@tfogo Could you update the make commands you added to use backtick-bounded code blocks, to conform with the rest of the document?

@tfogo
Copy link
Contributor Author

tfogo commented Aug 22, 2018

@lucperkins will do

@lucperkins
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2018
@kbarnard10
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbarnard10, lucperkins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8071564 into kubernetes:master Aug 22, 2018
rosti pushed a commit to rosti/website that referenced this pull request Aug 23, 2018
@tfogo @rosti
Add instructions for staging site using Docker (kubernetes#9217)
f7b735c 
* Add instructions for staging site using Docker

Adds a condensed version of the instructions in the README to
the intermediate contribution page.

* Format code blocks
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Aug 28, 2018
@tfogo
Add instructions for staging site using Docker (kubernetes#9217)
286061b 
* Add instructions for staging site using Docker

Adds a condensed version of the instructions in the README to
the intermediate contribution page.

* Format code blocks
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Aug 28, 2018
@tfogo
Add instructions for staging site using Docker (kubernetes#9217)
76e825c 
* Add instructions for staging site using Docker

Adds a condensed version of the instructions in the README to
the intermediate contribution page.

* Format code blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@lucperkins lucperkins

@bradtopol bradtopol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tfogo @k8sio-netlify-preview-bot @zacharysarah @lucperkins @kbarnard10 @k8s-ci-robot @bradtopol