Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old Dockerfile for Jekyll site #9215

Closed
wants to merge 1 commit into from

Conversation

tfogo
Copy link
Contributor

@tfogo tfogo commented Jun 25, 2018

PR #9128 added a new Dockerfile for the Hugo site. The old
staging container is no longer needed.

PR kubernetes#9128 added a new Dockerfile for the Hugo site. The old
staging container is no longer needed.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mistyhacks

Assign the PR to them by writing /assign @mistyhacks in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tfogo
Copy link
Contributor Author

tfogo commented Jun 25, 2018

/assign @MistyHacks

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 64e9595

https://deploy-preview-9215--kubernetes-io-master-staging.netlify.com

@mdlinville
Copy link
Contributor

@lucperkins Should you cherry-pick your commit from your other PR into this one, to keep all of this type of work into one PR?

@lucperkins
Copy link
Contributor

@tfogo I agree with @MistyHacks that it'd be best to consolidate the Docker-related changes into a single PR.

@tfogo
Copy link
Contributor Author

tfogo commented Jun 27, 2018

@lucperkins sure thing. @MistyHacks is there a PR from @lucperkins that should be cherry picked into this one or did you mean from my other PR touching the Dockerfile (#9216)?

@chenopis
Copy link
Contributor

/hold
Consolidate the PRs and close the one that's no longer needed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2018
@tfogo
Copy link
Contributor Author

tfogo commented Jul 20, 2018

This has been consolidated into #9216. Closing this PR.

@tfogo tfogo closed this Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants