Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the OCI runtime description. #7769

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Conversation

warmchang
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f049906

https://deploy-preview-7769--kubernetes-io-master-staging.netlify.com

@zhangxiaoyu-zidif
Copy link
Contributor

/cc @yujuhong or @Random-Liu for technical lgtm.

@steveperry-53
Copy link
Contributor

/assign

@steveperry-53
Copy link
Contributor

/approve (for writing)
Still need /lgtm for technical accuracy.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2018
@yujuhong
Copy link
Contributor

The description is incorrect.

Kubernetes has moved on to using the Container Runtime Interface (CRI) abstraction for runtime integration. Docker is supported through the built-in integration, while other runtimes (e.g., cri-o, containerd) are developed in their own repositories. There is no direct "OCI" runtime integration even though many CRI implementations do support pluggable OCI runtimes underneath. The old rktnetes integration has been deprecated in 1.10 and is scheduled to be removed in 1.11.

@warmchang
Copy link
Contributor Author

@yujuhong Your description is correct, Kubernetes has moved on to using the CRI for runtime integration and Docker is a built-in integration for historical reasons.

Like the CNI, the CRI defines the runtime interface, and users can implement the runtime themselves (runc, rkt, clearcontainer and so on).

This section describes the runtime info, so it should list the commonly used runtime listings, just like the networking plugin for CNI.

Or we should add CRI-related information, not just the container runtime (it is incomplete).

@zacharysarah
Copy link
Contributor

/assign @yujuhong
/assign @Random-Liu

@heckj
Copy link
Contributor

heckj commented Mar 23, 2018

verified technical correctness

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heckj, steveperry-53

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [heckj,steveperry-53]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 12d9230 into kubernetes:master Mar 23, 2018
@yujuhong
Copy link
Contributor

@heckj but I commented and said this is incorrect: #7769 (comment)

@heckj
Copy link
Contributor

heckj commented Mar 23, 2018

@yujuhong i apologize, as i read through the comments and thought the matter was resolved. can you submit a PR that is a correction and assign it to me?

chenopis added a commit that referenced this pull request Mar 27, 2018
…elease-1.9

* 'master' of https://github.com/kubernetes/website: (549 commits)
  Update service.md (#7810)
  Prune inactive maintainers (#7830)
  add Amadeus to index page and add feature image (#7827)
  Update conventions.md (#7668)
  Adding Tenxcloud as KCSP and Hedvig typo (#7826)
  Update outdated documentation about secret key validation. (#7675)
  Update imperative-command.md (#7699)
  Update manage-deployment.md (#7774)
  Add the OCI runtime description. (#7769)
  fix flag (#7814)
  fix flag (#7813)
  Add files via upload (#7816)
  Remove CoreOS guide that use Kubernetes v0.15.0 (#7821)
  "Nagions" should be "Nagios“ (#7762)
  Update docker-cli-to-kubectl.md (#7748)
  adjust a note format (#7812)
  add a note when mount a configmap to pod (#7745)
  Make using sysctls a task instead of a concept (#6808)
  Partners page updates (#7802)
  Fix a missing word in endpoint reconciler section (#7804)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants