Naming clarification #7677
Naming clarification #7677
Conversation
It isn't mentioned that this is crucial to get etcd working.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit b0c3b08 https://deploy-preview-7677--kubernetes-io-master-staging.netlify.com |
|
This looks very good to me. @spzala can you serve as tech reviewer for this. Simply add a /lgtm |
| @@ -282,7 +282,7 @@ Please select one of the tabs to see installation instructions for the respectiv | |||
| EOF | |||
| ``` | |||
|
|
|||
| Make sure you replace `<etcd0-ip-address>`, `<etcd1-ip-address>` and `<etcd2-ip-address>` with the appropriate IPv4 addresses. | |||
| Make sure you replace `<etcd0-ip-address>`, `<etcd1-ip-address>` and `<etcd2-ip-address>` with the appropriate IPv4 addresses. Also, make sure that you changed `<etcd0>`, `<etcd1>` and `<etcd2>` with real hostnames of each machine and that these machines are able to reach each other using DNS or add records to `/etc/hosts`. | |||
There was a problem hiding this comment.
| add records to /etc/hosts.
records added to /etc/hosts.
There was a problem hiding this comment.
Nit.."Make sure you replace" vs "make sure that you changed" ... it would be nice to have both sentences use consistency. Thanks!
There was a problem hiding this comment.
I hope it's good now.
|
I had a small nit as commented inline but it looks great from etcd side, |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bradtopol, spzala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
It isn't mentioned that this is crucial to get etcd working.